[CELEBORN-1632] Support to apply ratis local raft_meta_conf command with RESTful api#2829
Closed
turboFei wants to merge 4 commits into
Closed
[CELEBORN-1632] Support to apply ratis local raft_meta_conf command with RESTful api#2829turboFei wants to merge 4 commits into
turboFei wants to merge 4 commits into
Conversation
turboFei
changed the title
turboFei
force-pushed
the
local_raft_conf
branch
from
9254c91 to
9d2aa17
Compare
turboFei
force-pushed
the
local_raft_conf
branch
from
9d2aa17 to
03c188f
Compare
SteNicholas
approved these changes
Oct 21, 2024
Member
Author
will self review the logical again, we may need to allow to replace the existing peer. |
Member
Author
|
Have update the logical to allow to replace the existing peers. |
method name
turboFei
force-pushed
the
local_raft_conf
branch
from
cd407ab to
771158e
Compare
Member
Author
cc @RexXiong |
RexXiong
approved these changes
Oct 24, 2024
Contributor
|
Thanks, merge to main(v0.6.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sub-task of CELEBORN-1628.
Support to apply ratis local raft_meta_conf with RESTful api.
See https://celeborn.apache.org/docs/latest/celeborn_ratis_shell/#local-raftmetaconf
The implementation is same with https://github.com/apache/ratis/blob/e96ed1a33840385446f4e647864a169467da5ab7/ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/local/RaftMetaConfCommand.java#L122-L133
Why are the changes needed?
We have implemented the RESTful implementation for all the others ratis-shell command.
/ratis/election/transfer/ratis/election/step_down/ratis/election/pause/ratis/election/resume/masters/ratis/peer/add/ratis/peer/remove/ratis/peer/set_priority/ratis/snapshot/createAnd the local raftMetaConf command is the last one.
I closed the ticket CELEBORN-1632 before, I thought it is a local command and wonder whether it is necessary to implement it with RESTful api.
But we have implemented all the others, so I decide to implement it as well.
Does this PR introduce any user-facing change?
A new API.
The implementation is same with https://github.com/apache/ratis/blob/e96ed1a33840385446f4e647864a169467da5ab7/ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/local/RaftMetaConfCommand.java#L122-L133
How was this patch tested?