[CELEBORN-1663][FOLLOWUP] Only register appShuffleDeterminate if stage using celeborn for shuffle#2837
Closed
s0nskar wants to merge 1 commit into
Closed
[CELEBORN-1663][FOLLOWUP] Only register appShuffleDeterminate if stage using celeborn for shuffle#2837s0nskar wants to merge 1 commit into
s0nskar wants to merge 1 commit into
Conversation
SteNicholas
approved these changes
Oct 22, 2024
SteNicholas
pushed a commit
to SteNicholas/celeborn
that referenced
this pull request
Oct 22, 2024
…e using celeborn for shuffle Making the same changes for Spark2 codebase Followup for apache#2832 NA Existing UTs Closes apache#2837 from s0nskar/fix_register_spark2. Authored-by: Sanskar Modi <sanskarmodi97@gmail.com> Signed-off-by: SteNicholas <programgeek@163.com> (cherry picked from commit 1e77f01) Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Making the same changes for Spark2 codebase
Why are the changes needed?
Followup for #2832
Does this PR introduce any user-facing change?
NA
How was this patch tested?
Existing UTs