[CELEBORN-1699] Add GA to check the openapi codegen#2893
Closed
turboFei wants to merge 6 commits intoapache:mainfrom
Closed
[CELEBORN-1699] Add GA to check the openapi codegen#2893turboFei wants to merge 6 commits intoapache:mainfrom
turboFei wants to merge 6 commits intoapache:mainfrom
Conversation
turboFei
force-pushed
the
diff_openapi
branch
from
4328880 to
2cd91d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
==========================================
- Coverage 32.35% 32.11% -0.24%
==========================================
Files 329 329
Lines 19511 19686 +175
Branches 1752 1776 +24
==========================================
+ Hits 6311 6320 +9
- Misses 12855 13020 +165
- Partials 345 346 +1 ☔ View full report in Codecov by Sentry. |
turboFei
added a commit
to turboFei/incubator-celeborn
that referenced
this pull request
Nov 8, 2024
SteNicholas
approved these changes
Nov 8, 2024
SteNicholas
reviewed
Nov 8, 2024
SteNicholas
approved these changes
Nov 8, 2024
Member
|
@turboFei, thanks for update. Merged to main(v0.6.0). |
turboFei
added a commit
to turboFei/incubator-celeborn
that referenced
this pull request
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Check the consistency between openapi spec and generated openapi-client code in GA.
Fix the ThreadStack model.
Why are the changes needed?
Address comments: #2892 (comment)
Followup for #2888
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.
It works:
https://github.com/apache/celeborn/actions/runs/11733693060/job/32688436233?pr=2893
After ThreadStack fixed:
