[CELEBORN-1719] Introduce celeborn.client.spark.stageRerun.enabled with alternative celeborn.client.spark.fetch.throwsFetchFailure to enable spark stage rerun#2920
Closed
SteNicholas wants to merge 1 commit into
Conversation
…th alternative celeborn.client.spark.fetch.throwsFetchFailure to enable spark stage rerun
SteNicholas
force-pushed
the
CELEBORN-1719
branch
from
58f70c4 to
0639b28
Compare
Contributor
|
LGTM |
RexXiong
approved these changes
Nov 20, 2024
Member
Author
|
Merged to main(v0.6.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
celeborn.client.spark.stageRerun.enabledwith alternativeceleborn.client.spark.fetch.throwsFetchFailureto enable spark stage rerun.celeborn.client.spark.fetch.throwsFetchFailurefromfalsetotrue, which enables spark stage rerun at default.Why are the changes needed?
User could not directly understand the meaning of
celeborn.client.spark.fetch.throwsFetchFailureas whether to enable stage rerun, which means that client throwsFetchFailedExceptioninstead ofCelebornIOException. It's recommended to introduceceleborn.client.spark.stageRerun.enabledwith alternativeceleborn.client.spark.fetch.throwsFetchFailureto enable spark stage rerun.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.