[CELEBORN-1726] Update WorkerInfo when transition worker state#2930
Closed
reswqa wants to merge 4 commits into
Closed
[CELEBORN-1726] Update WorkerInfo when transition worker state#2930reswqa wants to merge 4 commits into
reswqa wants to merge 4 commits into
Conversation
SteNicholas
reviewed
Nov 20, 2024
SteNicholas
approved these changes
Nov 20, 2024
RexXiong
approved these changes
Nov 20, 2024
RexXiong
pushed a commit
that referenced
this pull request
Nov 20, 2024
### What changes were proposed in this pull request? Update WorkerInfo when transition worker state ### Why are the changes needed? When we send a `getWorkerInfo` request to the `Worker` node after this worker has became `Decommission` state , it does not return the correct state. note: If we send this request to `Master` node instead of `Worker`, the return value is correct. We should update the worker state also for worker node itself. ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Mannually Closes #2930 from reswqa/worker_info. Authored-by: Weijie Guo <reswqa@163.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit bb96a5f) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update WorkerInfo when transition worker state
Why are the changes needed?
When we send a
getWorkerInforequest to theWorkernode after this worker has becameDecommissionstate , it does not return the correct state.note: If we send this request to
Masternode instead ofWorker, the return value is correct. We should update the worker state also for worker node itself.Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Mannually