[CELEBORN-1700] Flink supports fallback to vanilla Flink built-in shuffle implementation#2932
Closed
SteNicholas wants to merge 3 commits into
Closed
[CELEBORN-1700] Flink supports fallback to vanilla Flink built-in shuffle implementation#2932SteNicholas wants to merge 3 commits into
SteNicholas wants to merge 3 commits into
Conversation
bb83198 to
85d5429
Compare
85d5429 to
6321ad8
Compare
Member
Author
|
Ping @reswqa, @codenohup, @RexXiong. |
reswqa
reviewed
Nov 21, 2024
1f57391 to
dfc93da
Compare
codenohup
approved these changes
Nov 22, 2024
Contributor
codenohup
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution!
Member
Author
dfc93da to
6f68761
Compare
…ffle implementation
…ffle implementation
6f68761 to
e4dbe45
Compare
…ffle implementation
e4dbe45 to
83e9555
Compare
RexXiong
approved these changes
Nov 27, 2024
Contributor
|
Thanks, merge to main(v0.6.0) |
FMX
pushed a commit
that referenced
this pull request
Dec 20, 2024
…lback to vanilla Flink built-in shuffle implementation ### What changes were proposed in this pull request? Support `ShuffleFallbackCount` metric for fallback to vanilla Flink built-in shuffle implementation. ### Why are the changes needed? #2932 has already supported fallback to vanilla Flink built-in shuffle implementation, which is lack of `ShuffleFallbackCount` metric to feedback the situation of fallback. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `RemoteShuffleMasterSuiteJ#testRegisterPartitionWithProducerForForceFallbackPolicy` Closes #3012 from SteNicholas/CELEBORN-1700. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Flink supports fallback to vanilla Flink built-in shuffle implementation.
Why are the changes needed?
When quota is unenough or workers are unavailable,
RemoteShuffleMasterdoes not support fallback toNettyShuffleMaster, andRemoteShuffleEnvironmentdoes not support fallback toNettyShuffleEnvironmentat present. Flink should support fallback to vanilla Flink built-in shuffle implementation for unenough quota and unavailable workers.Does this PR introduce any user-facing change?
ShuffleFallbackPolicyinterface to determine whether fallback to vanilla Flink built-in shuffle implementation.celeborn.client.flink.shuffle.fallback.policyconfig to support shuffle fallback policy configuration.How was this patch tested?
RemoteShuffleMasterSuiteJ#testRegisterJobWithForceFallbackPolicyWordCountTestBase#celeborn flink integration test with fallback - word count