[CELEBORN-1754][CIP-14] Add exceptions and checking utils to cppClient#2966
[CELEBORN-1754][CIP-14] Add exceptions and checking utils to cppClient#2966HolyLow wants to merge 4 commits intoapache:mainfrom
Conversation
|
@FMX Could you kindly help review this PR? Thanks a lot. Also note that the prebuild dev image is updated to holylow/celeborn-cpp-dev:0.2 to add gtest module dependency. Any suggestion is welcome. |
|
Copy that. I'll review this PR within this week. |
|
@HolyLow I found out that I can run the UTs successfully. If I run the UTs in Clion, I got following error. If I run the UTs in Docker container, I got following errors. |
|
Looks like there is something wrong with the UT, I'll merge this PR after it is fixed. |
|
After some investigation, I found the errors that occurred were related to the difference between the arm64 and the x86 platforms. I'll merge this PR. Docker saved the day. |
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0).
What changes were proposed in this pull request?
This PR adds exceptions and checking utils code to CppClient.
Besides, the ctest framework is added to CppClient for UTs.
Why are the changes needed?
To provide exception utils and UT frmework to CppClient.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and UTs.