[CELEBORN-1758] Remove the empty user resource consumption from worker heartbeat#2967
Closed
turboFei wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1758] Remove the empty user resource consumption from worker heartbeat#2967turboFei wants to merge 1 commit intoapache:mainfrom
turboFei wants to merge 1 commit intoapache:mainfrom
Conversation
18637f0 to
a9dfdba
Compare
FMX
approved these changes
Dec 2, 2024
Contributor
FMX
left a comment
There was a problem hiding this comment.
LGTM. After checking all related codes, this PR won't introduce trouble. But I'll leave this PR for others to merge.
Member
|
Merged to main(v0.6.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
resourceConsumptionSnapshotfromstorageManagerdirectly in the worker heartbeat, which does not contain the empty user resource consumptionWhy are the changes needed?
celeborn/common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala
Lines 239 to 248 in 878a83c
Currently, we never remove the user resource consumption even the sub resource consumptions is empty, and create a
ResourceConsumption(0, 0, 0, 0)instead.I am afraid that, the worker will report more and more empty user resource consumption to master, once one of their slots assigned to this worker.
Likes:

So, I think we just need to report the
resourceConsumptionSnapshotfromstorageManagerdirectly, which does not contain the empty user resource consumption.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.