[CELEBORN-1770] FlushNotifier should setException for all Throwables in Flusher#2988
Closed
zaynt4606 wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1770] FlushNotifier should setException for all Throwables in Flusher#2988zaynt4606 wants to merge 1 commit intoapache:mainfrom
zaynt4606 wants to merge 1 commit intoapache:mainfrom
Conversation
RexXiong
approved these changes
Dec 12, 2024
RexXiong
pushed a commit
that referenced
this pull request
Dec 12, 2024
…in Flusher ### What changes were proposed in this pull request? Non-IOException (will throw illegalReferenceCountException If a netty's buffer reference count is incorrect) should also be set in FlushNotifier. Provides Utils to convert non-IOExceptions to IOExceptions. ### Why are the changes needed? In some test scenarios where data replication is enabled and workers are randomly terminated, it will throw illegalReferenceCountException which won't be caught.  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UT & cluster test. Closes #2988 from zaynt4606/clb1770-m. Authored-by: zhengtao <shuaizhentao.szt@alibaba-inc.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit f7b036d) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
RexXiong
pushed a commit
that referenced
this pull request
Dec 12, 2024
…in Flusher Non-IOException (will throw illegalReferenceCountException If a netty's buffer reference count is incorrect) should also be set in FlushNotifier. Provides Utils to convert non-IOExceptions to IOExceptions. In some test scenarios where data replication is enabled and workers are randomly terminated, it will throw illegalReferenceCountException which won't be caught.  No. Existing UT & cluster test. Closes #2988 from zaynt4606/clb1770-m. Authored-by: zhengtao <shuaizhentao.szt@alibaba-inc.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit f7b036d) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
RexXiong
pushed a commit
that referenced
this pull request
Apr 17, 2025
…in Flusher ### What changes were proposed in this pull request? Non-IOException (will throw illegalReferenceCountException If a netty's buffer reference count is incorrect) should also be set in FlushNotifier. Provides Utils to convert non-IOExceptions to IOExceptions. ### Why are the changes needed? In some test scenarios where data replication is enabled and workers are randomly terminated, it will throw illegalReferenceCountException which won't be caught.  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UT & cluster test. Closes #2988 from zaynt4606/clb1770-m. Authored-by: zhengtao <shuaizhentao.szt@alibaba-inc.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit f7b036d) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Non-IOException (will throw illegalReferenceCountException If a netty's buffer reference count is incorrect)
should also be set in FlushNotifier.
Provides Utils to convert non-IOExceptions to IOExceptions.
Why are the changes needed?
In some test scenarios where data replication is enabled and workers are randomly terminated, it will throw illegalReferenceCountException which won't be caught.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT & cluster test.