[CELEBORN-1477][FOLLOWUP] Minor fix for v1 RESTful apis before release #3023
Closed
turboFei wants to merge 2 commits intoapache:mainfrom
Closed
[CELEBORN-1477][FOLLOWUP] Minor fix for v1 RESTful apis before release #3023turboFei wants to merge 2 commits intoapache:mainfrom
turboFei wants to merge 2 commits intoapache:mainfrom
Conversation
turboFei
changed the title
turboFei
changed the title
Contributor
|
Is this PR needed for release 0.5.3? |
Member
Author
no, only for 0.6.0 |
RexXiong
approved these changes
Jan 2, 2025
Contributor
|
Thanks, merge to main(v0.6.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Minor fix the v1 RESTful apis before 0.6.0 release.
subResourceConsumption=>subResourceConsumptions.Why are the changes needed?
useEnumCaseInsensitivefor openapi-generator #2754, the openapi-sdk works well. but for the RESTful call without SDK, the worker eventType is still case sensitive, might be caused by the jersey issue mentioned in enum should be serialized with name and not default toString eclipse-ee4j/jersey#5288. So, In this PR, I change the description in the swagger for user guidance.subResourceConsumptiontosubResourceConsumptions.Does this PR introduce any user-facing change?
No, the api has not been released.
How was this patch tested?
GA.