[CELEBORN-1821][CIP-14] Add controlMessages to cppClient#3052
Closed
HolyLow wants to merge 2 commits intoapache:mainfrom
Closed
[CELEBORN-1821][CIP-14] Add controlMessages to cppClient#3052HolyLow wants to merge 2 commits intoapache:mainfrom
HolyLow wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
RexXiong
reviewed
Jan 6, 2025
| auto fileGroups = pbGetReducerFileGroupResponse->filegroups(); | ||
| for (auto& kv : fileGroups) { | ||
| auto& fileGroup = response->fileGroups[kv.first]; | ||
| // Legacy mode: the locations are valid, so use it. |
Contributor
There was a problem hiding this comment.
shall we need support legacy mode?
Contributor
Author
There was a problem hiding this comment.
In java end, the legacy mode is kept for backward compatibility. I think keeping legacy mode in CppClient does no harm, or should we simply throw an error here if the legacy mode is detected?
Any suggestion is welcome.
Contributor
There was a problem hiding this comment.
Native SDK will be shipped in 0.6 or 0.7. Should use new format as default.
Contributor
Author
There was a problem hiding this comment.
Refactored as requested.
Any suggestion is welcome.
RexXiong
approved these changes
Jan 8, 2025
Contributor
|
Merged into main(v0.6.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds ControlMessages to cppClient.
Why are the changes needed?
The ControlMessages are used to communicate with the CelebornServer and LifecycleManager.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and UTs.