[CELEBORN-1879] Ignore invalid chunk range generated by splitSkewedPartitionLocations#3117
Closed
Z1Wu wants to merge 2 commits intoapache:mainfrom
Closed
[CELEBORN-1879] Ignore invalid chunk range generated by splitSkewedPartitionLocations#3117Z1Wu wants to merge 2 commits intoapache:mainfrom
Z1Wu wants to merge 2 commits intoapache:mainfrom
Conversation
…aller than chunk size.
Member
Contributor
|
Thank you for the fix! The bug was introduced in #2373 |
cfmcgrady
approved these changes
Feb 25, 2025
RexXiong
approved these changes
Feb 26, 2025
Contributor
|
Thanks, merge to main(v0.6.0) |
RexXiong
pushed a commit
that referenced
this pull request
Apr 17, 2025
…rtitionLocations Ignore invalid chunk range generated by splitSkewedPartitionLocations Current implementation of skew partition split method (`splitSkewedPartitionLocations`) may generate chunk range where `range.left` > `range.right`. Such chunk range is invalid and will cause unnecessary initialization of `PartitionReader` no ut Closes #3117 from Z1Wu/feat/c1879. Authored-by: wuziyi <wuziyi02@corp.netease.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ignore invalid chunk range generated by splitSkewedPartitionLocations
Why are the changes needed?
Current implementation of skew partition split method (
splitSkewedPartitionLocations) may generate chunk range whererange.left>range.right. Such chunk range is invalid and will cause unnecessary initialization ofPartitionReaderDoes this PR introduce any user-facing change?
no
How was this patch tested?
ut