[CELEBORN-1897] Avoid calling toString for too long messages#3139
Closed
CodingCat wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1897] Avoid calling toString for too long messages#3139CodingCat wants to merge 1 commit intoapache:mainfrom
CodingCat wants to merge 1 commit intoapache:mainfrom
Conversation
RexXiong
approved these changes
Mar 10, 2025
SteNicholas
changed the title
SteNicholas
pushed a commit
that referenced
this pull request
Mar 10, 2025
### What changes were proposed in this pull request? https://github.com/apache/celeborn/blob/196ad607cd62af83b1ace887b8eb91d548fc36ac/common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala#L256 we hit the issue that the ignored message is too long , and when calling toString, it applies for a too large array which is beyond the JVM's limit I don't think this log convey too much info, , so we could avoid calling toString to improve robustness of the applications ### Why are the changes needed? more details in JIRA ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? prod Closes #3139 from CodingCat/log. Authored-by: CodingCat <zhunansjtu@gmail.com> Signed-off-by: SteNicholas <programgeek@163.com> (cherry picked from commit 18b268d) Signed-off-by: SteNicholas <programgeek@163.com>
Member
|
Merged to main(v0.6.0) and branch-0.5(v0.5.4). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
celeborn/common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala
Line 256 in 196ad60
I don't think this log convey too much info, , so we could avoid calling toString to improve robustness of the applications
Why are the changes needed?
more details in JIRA
Does this PR introduce any user-facing change?
no
How was this patch tested?
prod