[CELEBORN-1898] SparkOutOfMemoryError compatible with Spark 4.0 and 4.1#3141
Closed
pan3793 wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1898] SparkOutOfMemoryError compatible with Spark 4.0 and 4.1#3141pan3793 wants to merge 1 commit intoapache:mainfrom
pan3793 wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
cc @SteNicholas @FMX, the upstream change happens after Spark 4.0.0-preview2 |
SteNicholas
approved these changes
Mar 10, 2025
FMX
approved these changes
Mar 10, 2025
Contributor
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. This PR is beyond the expectation. Merged into main(v0.6.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-49946 (4.0.0) removes single String constructor of class
SparkOutOfMemoryErrorand introduces_LEGACY_ERROR_TEMP_3301error condition, SPARK-51386 (4.1.0) renames the error condition toPOINTER_ARRAY_OUT_OF_MEMORY.Why are the changes needed?
To be compatible with Spark 4.0 and 4.1
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GHA checks Spark 2.4 to Spark 3.5, I manually tested with Spark 4.0.0 RC2