[CELEBORN-81][FOLLOWUP]Correct scala test plugin args.#3205
Closed
gaoyajun02 wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-81][FOLLOWUP]Correct scala test plugin args.#3205gaoyajun02 wants to merge 1 commit intoapache:mainfrom
gaoyajun02 wants to merge 1 commit intoapache:mainfrom
Conversation
gaoyajun02
changed the title
Author
|
This is a screenshot of our internal CI coverage report, using the master and worker modules as examples. After PR changes: PTAL. @FMX |
RexXiong
pushed a commit
that referenced
this pull request
Apr 9, 2025
### What changes were proposed in this pull request? Modifies the maven configuration to properly pass Jacoco's argLine to ScalaTest plugin, enabling code coverage measurement for Scala tests. ### Why are the changes needed? Previously Scala tests were not properly included in code coverage reports ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI Closes #3205 from gaoyajun02/ci. Authored-by: gaoyajun02 <gaoyajun02@meituan.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit e5ccc9b) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
Contributor
|
Thanks merge to main(v0.6.0) and branch-0.5(0.5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modifies the maven configuration to properly pass Jacoco's argLine to ScalaTest plugin, enabling code coverage measurement for Scala tests.
Why are the changes needed?
Previously Scala tests were not properly included in code coverage reports
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI