[CELEBORN-2194] Change default value of celeborn.worker.directMemoryRatioForReadBuffer#3527
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-2194] Change default value of celeborn.worker.directMemoryRatioForReadBuffer#3527SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas wants to merge 1 commit intoapache:mainfrom
Conversation
…atioForReadBuffer
RexXiong
approved these changes
Nov 4, 2025
Member
Author
|
Merged to main(v0.7.0). |
SteNicholas
added a commit
that referenced
this pull request
Nov 4, 2025
…atioForReadBuffer ### What changes were proposed in this pull request? Change default value of `celeborn.worker.directMemoryRatioForReadBuffer` from 0.1 to 0.35. ### Why are the changes needed? The default value of `celeborn.worker.directMemoryRatioForReadBuffer` is 0.1, which is too small to cause a backlog of read buffer requests in `ReadBufferDispacther`. Therefore, `celeborn.worker.directMemoryRatioForReadBuffer` should be changed from `0.1` to `0.35` which is production practice value to raise read buffer threshold of `ReadBufferDispatcher`. ### Does this PR resolve a correctness bug? No. ### Does this PR introduce _any_ user-facing change? The default value of `celeborn.worker.directMemoryRatioForReadBuffer` is changed to 0.35. ### How was this patch tested? CI. Closes #3527 from SteNicholas/CELEBORN-2194. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change default value of
celeborn.worker.directMemoryRatioForReadBufferfrom 0.1 to 0.35.Why are the changes needed?
The default value of
celeborn.worker.directMemoryRatioForReadBufferis 0.1, which is too small to cause a backlog of read buffer requests inReadBufferDispacther. Therefore,celeborn.worker.directMemoryRatioForReadBuffershould be changed from0.1to0.35which is production practice value to raise read buffer threshold ofReadBufferDispatcher.Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
The default value of
celeborn.worker.directMemoryRatioForReadBufferis changed to 0.35.How was this patch tested?
CI.