Skip to content

[CELEBORN-2203] Set celeborn.master.internal.endpoints in the configmap#3536

Closed
pingzh wants to merge 1 commit intoapache:mainfrom
pingzh:dev/pingz-celeborn.master.internal.endpoints
Closed

[CELEBORN-2203] Set celeborn.master.internal.endpoints in the configmap#3536
pingzh wants to merge 1 commit intoapache:mainfrom
pingzh:dev/pingz-celeborn.master.internal.endpoints

Conversation

@pingzh
Copy link
Contributor

@pingzh pingzh commented Nov 10, 2025

What changes were proposed in this pull request?

Set celeborn.master.internal.endpoints in the configmap.

Why are the changes needed?

The default value is <localhost>:8097 right now, which cause that workers fail to start as it cannot connect to that port.

Does this PR resolve a correctness bug?

No.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

image

so that workers can use the dns to connect to the master
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ChenYi015
Copy link
Contributor

LGTM.

SteNicholas pushed a commit that referenced this pull request Nov 17, 2025
### What changes were proposed in this pull request?

Set `celeborn.master.internal.endpoints` in the configmap.

### Why are the changes needed?

The default value is `<localhost>:8097` right now, which cause that workers fail to start as it cannot connect to that port.

### Does this PR resolve a correctness bug?

No.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

<img width="2732" height="1104" alt="image" src="https://github.com/user-attachments/assets/542b6554-61c1-4c7b-a7bc-718cdcd50176" />

Closes #3536 from pingzh/dev/pingz-celeborn.master.internal.endpoints.

Authored-by: Ping Zhang <ping.goblue@gmail.com>
Signed-off-by: SteNicholas <programgeek@163.com>
(cherry picked from commit b678991)
Signed-off-by: SteNicholas <programgeek@163.com>
@SteNicholas
Copy link
Member

Merged to main(v0.7.0) and branch-0.6(v0.6.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants