[MINOR] Add calculation steps for tuning section#3537
Closed
pingzh wants to merge 1 commit intoapache:mainfrom
Closed
[MINOR] Add calculation steps for tuning section#3537pingzh wants to merge 1 commit intoapache:mainfrom
pingzh wants to merge 1 commit intoapache:mainfrom
Conversation
pingzh
force-pushed
the
dev/pingz-doc-tuning
branch
2 times, most recently
from
87b99d2 to
3227a12
Compare
Contributor
Author
|
hi @SteNicholas , could you you please take a quick look at this doc only changes? 🙏 |
Member
|
Hi @pingzh It is better that you can provide the screenshots for comparison (before & after) to help the reviewer understand the change better. |
turboFei
reviewed
Nov 12, 2025
pingzh
force-pushed
the
dev/pingz-doc-tuning
branch
from
3227a12 to
f0e3138
Compare
Contributor
Author
|
@turboFei update the pr description with before and after screenshot. could you please take a look? |
turboFei
approved these changes
Nov 13, 2025
Member
turboFei
left a comment
turboFei
left a comment
There was a problem hiding this comment.
LGTM
NIT: could you remove all others blank line change?
pingzh
force-pushed
the
dev/pingz-doc-tuning
branch
2 times, most recently
from
5d3ca5d to
09b8ca6
Compare
Contributor
Author
|
@turboFei updated 🙏 |
SteNicholas
reviewed
Nov 14, 2025
pingzh
force-pushed
the
dev/pingz-doc-tuning
branch
from
09b8ca6 to
49c16f9
Compare
SteNicholas
pushed a commit
that referenced
this pull request
Nov 14, 2025
### What changes were proposed in this pull request? per title ### Why are the changes needed? so that readers can easily understand the process ### Does this PR resolve a correctness bug? No ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? before: <img width="2098" height="594" alt="image" src="https://github.com/user-attachments/assets/3b2a364b-1bf1-480f-b6cd-92c35a768a98" /> after <img width="2194" height="1122" alt="image" src="https://github.com/user-attachments/assets/8b37a50b-14ec-4926-bd52-e8fd5819ce29" /> Closes #3537 from pingzh/dev/pingz-doc-tuning. Authored-by: Ping Zhang <ping.goblue@gmail.com> Signed-off-by: SteNicholas <programgeek@163.com> (cherry picked from commit 2874227) Signed-off-by: SteNicholas <programgeek@163.com>
Member
|
Merged to main(v0.7.0) and branch-0.6(v0.6.2). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
per title
Why are the changes needed?
so that readers can easily understand the process
Does this PR resolve a correctness bug?
No
Does this PR introduce any user-facing change?
How was this patch tested?
before:
after