[CELEBORN-2196][CIP-14] Support ReviveManager in CppClient#3538
Closed
HolyLow wants to merge 4 commits intoapache:mainfrom
Closed
[CELEBORN-2196][CIP-14] Support ReviveManager in CppClient#3538HolyLow wants to merge 4 commits intoapache:mainfrom
HolyLow wants to merge 4 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@SteNicholas @RexXiong @FMX Could you kindly help review this PR? Thanks a lot. Any suggestion would be greatly appreciated. |
SteNicholas
reviewed
Nov 17, 2025
SteNicholas
reviewed
Nov 17, 2025
SteNicholas
reviewed
Nov 17, 2025
Member
SteNicholas
left a comment
SteNicholas
left a comment
There was a problem hiding this comment.
@HolyLow, thanks for contribution. I left two minor comments for this pull request. PTAL.
Contributor
Author
|
@SteNicholas Thanks for your comments, refactored as suggested. Any further suggestion would be greatly appreciated. |
Member
|
Merged to main(v0.7.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR supports ReviveManager in CppClient.
Why are the changes needed?
ReviveManager is the building component for writing procedure of CppClient.
Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and UTs.