[CELEBORN-2254] Fix support for S3 and add a simple integration test#3592
Closed
eolivelli wants to merge 11 commits intoapache:mainfrom
Closed
[CELEBORN-2254] Fix support for S3 and add a simple integration test#3592eolivelli wants to merge 11 commits intoapache:mainfrom
eolivelli wants to merge 11 commits intoapache:mainfrom
Conversation
github-actions
bot
added
module:client
kind:build
module:common
module:tests
module:worker
labels
SteNicholas
changed the title
Member
|
@eolivelli, thanks for contribution. Please run |
SteNicholas
requested changes
Feb 3, 2026
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/ChannelsLimiter.java
Outdated
Show resolved
Hide resolved
Contributor
Author
done |
eolivelli
commented
Feb 3, 2026
Contributor
Author
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
thank you @SteNicholas
I have addressed your comments
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/ChannelsLimiter.java
Outdated
Show resolved
Hide resolved
Dzeri96
reviewed
Feb 3, 2026
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
Outdated
Show resolved
Hide resolved
...loader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java
Show resolved
Hide resolved
...rk-it/src/test/scala/org/apache/celeborn/tests/spark/s3/BasicEndToEndTieredStorageTest.scala
Outdated
Show resolved
Hide resolved
eolivelli
commented
Feb 3, 2026
...loader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java
Show resolved
Hide resolved
...rk-it/src/test/scala/org/apache/celeborn/tests/spark/s3/BasicEndToEndTieredStorageTest.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
Outdated
Show resolved
Hide resolved
added 2 commits
February 3, 2026 12:13
Member
|
@eolivelli, you should update |
Dzeri96
approved these changes
Feb 3, 2026
Dzeri96
left a comment
Dzeri96
left a comment
There was a problem hiding this comment.
My feedback has been implemented. LGTM
Contributor
Author
|
I think that the failures are unrelated to the patch, is it possible to re-run only those jobs ? |
RexXiong
approved these changes
Feb 5, 2026
Contributor
RexXiong
left a comment
RexXiong
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
SteNicholas
pushed a commit
to SteNicholas/celeborn
that referenced
this pull request
Feb 5, 2026
### What changes were proposed in this pull request? * Fix creating files to S3 (and other DFS) * Add integration test for Spark and S3 (using Minio) * in CI some job will run with the AWS profile because this way we can activate the new integration test (that needs the S3 client dependencies) ### Why are the changes needed? See https://issues.apache.org/jira/browse/CELEBORN-2254. ### Does this PR resolve a correctness bug? No ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? * I have added an integration test * I have this patch on out internal fork, to make Celeborn run on k8s with S3 Closes apache#3592 from eolivelli/CELEBORN-2254-apache. Authored-by: Enrico Olivelli <enrico@beast.io> Signed-off-by: SteNicholas <programgeek@163.com>
Member
|
Thanks. Merged to main(v0.7.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
see https://issues.apache.org/jira/browse/CELEBORN-2254
Does this PR resolve a correctness bug?
No
Does this PR introduce any user-facing change?
No
How was this patch tested?