[CELEBORN-2302] Fix NPE in MemoryManager.close() when readBufferDispatcher is not initialized#3654
Closed
cxzl25 wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-2302] Fix NPE in MemoryManager.close() when readBufferDispatcher is not initialized#3654cxzl25 wants to merge 1 commit intoapache:mainfrom
cxzl25 wants to merge 1 commit intoapache:mainfrom
Conversation
RexXiong
approved these changes
Apr 7, 2026
SteNicholas
approved these changes
Apr 8, 2026
SteNicholas
pushed a commit
that referenced
this pull request
Apr 8, 2026
…tcher is not initialized ### What changes were proposed in this pull request? Add a null check for readBufferDispatcher before calling close() in MemoryManager.close(). ### Why are the changes needed? readBufferDispatcher is only initialized when readBufferThreshold > 0. ### Does this PR resolve a correctness bug? No ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GHA Closes #3654 from cxzl25/CELEBORN-2302. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: SteNicholas <programgeek@163.com> (cherry picked from commit 7f1bac3) Signed-off-by: SteNicholas <programgeek@163.com>
Member
|
Merged to main(v0.7.0) and branch-0.6(v0.6.3). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a null check for readBufferDispatcher before calling close() in MemoryManager.close().
Why are the changes needed?
readBufferDispatcher is only initialized when readBufferThreshold > 0.
Does this PR resolve a correctness bug?
No
Does this PR introduce any user-facing change?
No
How was this patch tested?
GHA