Skip to content

[CELEBORN-2308] Bump commons-lang3 version from 3.17.0 to 3.20.0#3663

Draft
cxzl25 wants to merge 2 commits intoapache:mainfrom
cxzl25:CELEBORN-2308
Draft

[CELEBORN-2308] Bump commons-lang3 version from 3.17.0 to 3.20.0#3663
cxzl25 wants to merge 2 commits intoapache:mainfrom
cxzl25:CELEBORN-2308

Conversation

@cxzl25
Copy link
Copy Markdown
Contributor

@cxzl25 cxzl25 commented Apr 13, 2026

What changes were proposed in this pull request?

https://commons.apache.org/proper/commons-lang/changes.html#a3.20.0

https://issues.apache.org/jira/browse/LANG-1786

Why are the changes needed?

JDK25

WARNING: Use of the three-letter time zone ID "IET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "JST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "IST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "BET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "ACT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "HST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AGT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "VST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CNT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "EST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "NET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PLT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "SST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CTT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PNT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "BST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "MIT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "ART" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PRT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "NST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "EAT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "MST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "ECT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CAT" is deprecated and it will be removed in a future release
	at java.base/java.util.TimeZone.getTimeZone(TimeZone.java:600)
	at java.base/java.util.TimeZone.getTimeZone(TimeZone.java:549)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateParser$TimeZoneStrategy.<init>(FastDateParser.java:920)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateParser.getLocaleSpecificStrategy(FastDateParser.java:661)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateParser.getStrategy(FastDateParser.java:630)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateParser.access$200(FastDateParser.java:75)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateParser$StrategyParser.letterPattern(FastDateParser.java:234)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateParser$StrategyParser.getNextStrategy(FastDateParser.java:220)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateParser.init(FastDateParser.java:163)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateParser.<init>(FastDateParser.java:149)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateFormat.<init>(FastDateFormat.java:399)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateFormat.<init>(FastDateFormat.java:383)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateFormat$1.createInstance(FastDateFormat.java:105)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateFormat$1.createInstance(FastDateFormat.java:102)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FormatCache.getInstance(FormatCache.java:79)
	at org.apache.celeborn.shaded.org.apache.commons.lang3.time.FastDateFormat.getInstance(FastDateFormat.java:162)
	at org.apache.celeborn.common.util.Utils$.<init>(Utils.scala:1238)
	at org.apache.celeborn.common.util.Utils$.<clinit>(Utils.scala)

https://bugs.openjdk.org/browse/JDK-8342550

Does this PR resolve a correctness bug?

No

Does this PR introduce any user-facing change?

No

How was this patch tested?

GHA

@cxzl25 cxzl25 marked this pull request as draft April 13, 2026 11:51
<lz4-java.group>org.lz4</lz4-java.group>
<lz4-java.version>1.8.0</lz4-java.version>
<scala.version>2.12.17</scala.version>
<scala.version>2.12.18</scala.version>
Copy link
Copy Markdown
Contributor Author

@cxzl25 cxzl25 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commons-lang3 version 3.20.0 uses JDK25 build, and the previous version used JDK17. This causes an error when compiling the 3.20.0 version of scala with a lower version.

  bad constant pool index: 0 at pos: 5375
     while compiling: /home/runner/work/celeborn/celeborn/master/src/main/scala/org/apache/celeborn/service/deploy/master/InternalRpcEndpoint.scala
        during phase: globalPhase=jvm, enteringPhase=namer
     library version: version 2.12.15
    compiler version: version 2.12.15

https://github.com/apache/celeborn/actions/runs/24380964149/job/71204148341?pr=3663

https://github.com/scala/scala/pull/10397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant