[CELEBORN-1577][FOLLOWUP] Fix backward compatiblity issue with interrupt shuffle

[s0nskar]

What changes were proposed in this pull request?

Fix backward compatibility issue with interrupt shuffle by checking if the reason is nonEmpty.

Why are the changes needed?

If someone uses a new client with old server which is not sending CheckQuotaResponse in HeartbeatFromApplicationResponse then proto uses default value to build CheckQuotaResponse with isAvailable=false and reason="". In this case the job will always fails without breaching the quota, we should not fail the job if the reason is empty to make it backward compatible.

Does this PR resolve a correctness bug?

No

Does this PR introduce any user-facing change?

No

How was this patch tested?

Tested in local setup.

[RexXiong]

Using reason.nonEmpty as a proxy for "server supports quota check" is fragile — reason is a business description field, not a compatibility signal. If a legitimate quota-exceeded response happens to have an empty reason, it would be silently ignored; conversely, any future change to the reason format could break this logic.

Since quotaInterruptShuffleEnabled defaults to false, users must explicitly opt in. In a new-client/old-server scenario, users should simply not enable this config. This is an explicit and semantically clear approach, rather than relying on an implicit convention around the reason field.

If we do need robust backward compatibility, a better approach would be to add an explicit capability field (e.g., quotaCheckSupported) to the heartbeat response. But that's a larger change and can be addressed separately.

— Reviewed by Claude Code

[Copilot]

Pull request overview

Updates the client-side quota interrupt handling in ApplicationHeartbeater to be backward compatible with older masters that don’t populate checkQuotaResponse in HeartbeatFromApplicationResponse, preventing accidental job cancellation due to protobuf default values.

Changes:

• Gate shuffle interruption on CheckQuotaResponse.reason.nonEmpty in addition to !isAvailable.
• Avoid treating protobuf default isAvailable=false, reason="" (from missing message field) as a real quota-exceeded signal.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[SteNicholas]

@s0nskar, please rebase the latest main branch for Grafana Dashboard CI.

[SteNicholas]

@s0nskar, could you please help to update?

[s0nskar]

Ack, will work on this.

[SteNicholas]

@s0nskar, any update?

[s0nskar]

@SteNicholas / @RexXiong PTAL. Instead of adding a new field, i have made changes in the parsing of HeartbeatFromApplicationResponse.

[RexXiong]

LGTM

[SteNicholas]

LGTM.

[SteNicholas]

Thanks. Merged to main(v0.7.0).