Skip to content

Adds gitflow to build etcdlib standalone weekly.#236

Merged
rlenferink merged 1 commit intomasterfrom
feature/etcdlib_ci
May 19, 2020
Merged

Adds gitflow to build etcdlib standalone weekly.#236
rlenferink merged 1 commit intomasterfrom
feature/etcdlib_ci

Conversation

@pnoltes
Copy link
Copy Markdown
Contributor

@pnoltes pnoltes commented May 17, 2020

Also updated celix Promise to build weekly instead of nightly.

Also updated celix Promise to build weekly instead of nightly.
@pnoltes pnoltes requested review from abroekhuis and rlenferink May 17, 2020 14:28
@rlenferink
Copy link
Copy Markdown
Member

Also, I just noticed that we have an ubuntu.yml for push & pull_requests (Debug) and an ubuntu-nightly.yml for nightly builds (RelWithDebInfo). Maybe we should do this for the etcdlib as well?

@pnoltes
Copy link
Copy Markdown
Contributor Author

pnoltes commented May 17, 2020

Also, I just noticed that we have an ubuntu.yml for push & pull_requests (Debug) and an ubuntu-nightly.yml for nightly builds (RelWithDebInfo). Maybe we should do this for the etcdlib as well?

Also for this case I do not think this is needed. The nightly are added to ensure building with RelDefInfo also works. This is done nightly to prevent too much builds.
And because etcdlib is also build in the nigthly builds I do not see added value for creating a separate builds for that.

@rlenferink rlenferink merged commit de4a9a6 into master May 19, 2020
@pnoltes pnoltes deleted the feature/etcdlib_ci branch June 7, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants