Skip to content

Fixes an incorrect loop that installed bundles multiple times#239

Merged
pnoltes merged 1 commit intomasterfrom
hotfix/start_bundles_incorrect
May 20, 2020
Merged

Fixes an incorrect loop that installed bundles multiple times#239
pnoltes merged 1 commit intomasterfrom
hotfix/start_bundles_incorrect

Conversation

@pnoltes
Copy link
Copy Markdown
Contributor

@pnoltes pnoltes commented May 19, 2020

Fixes an issues where the framework was starting all bundles multiple times for the nr of possible run levels.
The list installedBundles is filled by the autoInstallBundlesForList call and only needs to be loop over once.

@pnoltes pnoltes requested a review from abroekhuis May 19, 2020 06:59
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2020

Codecov Report

Merging #239 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   67.83%   67.88%   +0.04%     
==========================================
  Files         127      127              
  Lines       26375    26374       -1     
==========================================
+ Hits        17891    17903      +12     
+ Misses       8484     8471      -13     
Impacted Files Coverage Δ
libs/framework/src/framework.c 75.50% <100.00%> (+0.19%) ⬆️
libs/utils/src/hash_map.c 94.23% <0.00%> (+0.86%) ⬆️
libs/framework/src/celix_log.c 89.06% <0.00%> (+10.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9959d8...8bd235d. Read the comment docs.

@pnoltes pnoltes merged commit 94e0ea4 into master May 20, 2020
@pnoltes pnoltes deleted the hotfix/start_bundles_incorrect branch May 20, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants