Skip to content

Conversation

@PengZheng
Copy link
Contributor

Break cyclic dependency between examples and other RSA tests.

It fixes #383

Break cyclic dependency between examples and other RSA tests.
@codecov-commenter
Copy link

Codecov Report

Merging #384 (9e2f814) into master (24d4f98) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   72.69%   72.70%           
=======================================
  Files         204      204           
  Lines       31268    31268           
=======================================
+ Hits        22730    22732    +2     
+ Misses       8538     8536    -2     
Impacted Files Coverage Δ
libs/utils/src/hash_map.c 93.25% <0.00%> (-0.29%) ⬇️
libs/framework/src/framework.c 77.55% <0.00%> (-0.07%) ⬇️
...dmin_websocket/src/pubsub_websocket_topic_sender.c 84.51% <0.00%> (+0.64%) ⬆️
...sub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c 88.18% <0.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d4f98...9e2f814. Read the comment docs.

Copy link
Contributor

@pnoltes pnoltes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnoltes pnoltes merged commit dacbc04 into apache:master Dec 21, 2021
@PengZheng PengZheng deleted the rsa_cmake_fix branch December 22, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Order of CMake add_subdirectory for remote services

3 participants