CLIMATE-467 - Handling various calendar types#102
CLIMATE-467 - Handling various calendar types#102huikyole wants to merge 7 commits intoapache:masterfrom
Conversation
…tion has been replaced by netCDF4.num2date function.
|
Can one of the admins verify this patch? |
… units with months
|
test this please |
|
Thanks for the PR @huikyole. I'll check it out ASAP |
|
Build triggered. Test Failed. |
|
Build started. Test Failed. |
|
Build finished. Test Passed. |
|
@huikyole, can you please squash down the CLIMATE-467 commits into fewer commits so they're grouped properly? Can you also split the CLIMATE-508 commits out into a separate pull request so we can test and review a single ticket worth of changes instead of multiple? Similarly, please make the commit messages more descriptive so someone can understand exactly why you're making the changes. A message with just "CLIMATE-467" or "CLIMATE-467 - additional debugging" doesn't help me understand what you're thinking =D Thanks again for the hard work on this. I'll throw some more reviews at the code once you've pushed these changes. If you're unsure how to squash or cherry-pick commits feel free to ask and someone will be more than happy to help out. |
|
Please disregard this pull request because we squashed the previous changes all together. |
No description provided.