Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

CLIMATE-467 - Handling various calendar types#102

Closed
huikyole wants to merge 7 commits intoapache:masterfrom
huikyole:stat_down
Closed

CLIMATE-467 - Handling various calendar types#102
huikyole wants to merge 7 commits intoapache:masterfrom
huikyole:stat_down

Conversation

@huikyole
Copy link

No description provided.

Huikyo Lee and others added 2 commits August 9, 2014 21:48
@OCWJenkins
Copy link

Can one of the admins verify this patch?

@MJJoyce
Copy link
Member

MJJoyce commented Aug 19, 2014

test this please

@MJJoyce
Copy link
Member

MJJoyce commented Aug 19, 2014

Thanks for the PR @huikyole. I'll check it out ASAP

@OCWJenkins
Copy link

Build triggered. Test Failed.

@OCWJenkins
Copy link

Build started. Test Failed.

@OCWJenkins
Copy link

Build finished. Test Passed.

@MJJoyce
Copy link
Member

MJJoyce commented Aug 19, 2014

@huikyole, can you please squash down the CLIMATE-467 commits into fewer commits so they're grouped properly? Can you also split the CLIMATE-508 commits out into a separate pull request so we can test and review a single ticket worth of changes instead of multiple? Similarly, please make the commit messages more descriptive so someone can understand exactly why you're making the changes. A message with just "CLIMATE-467" or "CLIMATE-467 - additional debugging" doesn't help me understand what you're thinking =D

Thanks again for the hard work on this. I'll throw some more reviews at the code once you've pushed these changes. If you're unsure how to squash or cherry-pick commits feel free to ask and someone will be more than happy to help out.

@huikyole
Copy link
Author

Please disregard this pull request because we squashed the previous changes all together.

@huikyole huikyole closed this Sep 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants