This repository was archived by the owner on May 12, 2021. It is now read-only.
CLIMATE-575 - Initial config based evaluation runner implementation #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MJJoyce
commented
Feb 9, 2015
MJJoyce
commented
- Implements initial config based execution of evaluations. There are a number of missing features, the most obvious of which is the lack of support for all the available plot types in OCW. These and other things will be updated in tickets that follow.
- Included is a config for one of our example files (simple_model_to_model_bias). The evaluation area is slightly changed, but other than that all is the same. It is assumed that the user has the files downloaded to /tmp when using this config file.
- Implement initial config based execution of evaluations. There are a number of missing features, the most obvious of which is the lack of support for all the available plot types in OCW. These and other things will be updated in tickets that follow.
- Fix bug in valid_plot_config helper that was left in from a copy-paste error. - Switch all yaml.safe_load calls to yaml.load to mirror the implementation. - Add tests for the contour map validation that is currently implemented. - Add tests for the generic plot config validation errors. - Add an additional check for the config_is_well_formed helper to ensure that invalid plot data is reported correctly.
|
Merged build triggered. Test Failed. |
|
Merged build started. Test Failed. |
|
Merged build finished. Test Passed. |
asfgit
pushed a commit
that referenced
this pull request
Feb 11, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.