This repository was archived by the owner on May 12, 2021. It is now read-only.
CLIMATE-643 - Updating unit conversion function #213
Merged
asfgit merged 1 commit intoapache:masterfrom Aug 3, 2015
Merged
Conversation
|
Merged build triggered. Test Failed. |
|
Merged build started. Test Failed. |
|
Merged build finished. Test Passed. |
Member
|
Good stuff @huikyole. Can I ask why we're copying the code from water_flux_unit_conversion nearly verbatim into this new function instead of just calling the existing code? That's just a maintenance mistake waiting to happen and it seems like it would be much more useful to separate out the functionality right? Then we don't have to maintain the exact same functionality in multiple places. |
Author
|
The issue (https://issues.apache.org/jira/browse/CLIMATE-643?jql=project%20%3D%20CLIMATE) has been updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases, observational and model datasets have different units for the same variable. We need to update variable_unit_conversion module is needed in dataset_processor. This new module is based on water_flux_unit_conversion.