feat(backup): Implement database-specific logic for Cloudberry#14
Merged
gfphoenix78 merged 1 commit intoapache:sync-with-upstreamfrom Aug 5, 2025
Merged
Conversation
Following the introduction of database type detection (GPDB vs. CBDB)
in the underlying common library, this commit applies that new
capability throughout the gpbackup codebase.
Previously, all version-based feature checks implicitly assumed the
target database was Greenplum. This was insufficient and could lead
to incorrect behavior when running against Apache Cloudberry Database,
as features might be enabled or disabled based on a versioning
scheme that doesn't apply.
This change systematically updates version-sensitive conditional
logic to be database-aware. It uses the new `IsGPDB()` and `IsCBDB()`
helpers to create compound checks.
For example, logic previously guarded by `version.AtLeast("7")` is now
updated to `(version.IsGPDB() && version.AtLeast("7")) || version.IsCBDB()`.
This correctly scopes features to specific GPDB versions while
enabling them by default for Cloudberry where appropriate.
This is a critical step to ensure that gpbackup functions reliably
and generates correct backup files for both Greenplum and Cloudberry
environments.
gfphoenix78
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the introduction of database type detection (GPDB vs. CBDB) in the underlying common library, this commit applies that new capability throughout the gpbackup codebase.
Previously, all version-based feature checks implicitly assumed the target database was Greenplum. This was insufficient and could lead to incorrect behavior when running against Apache Cloudberry Database, as features might be enabled or disabled based on a versioning scheme that doesn't apply.
This change systematically updates version-sensitive conditional logic to be database-aware. It uses the new
IsGPDB()andIsCBDB()helpers to create compound checks.For example, logic previously guarded by
version.AtLeast("7")is now updated to(version.IsGPDB() && version.AtLeast("7")) || version.IsCBDB(). This correctly scopes features to specific GPDB versions while enabling them by default for Cloudberry where appropriate.This is a critical step to ensure that gpbackup functions reliably and generates correct backup files for both Greenplum and Cloudberry environments.