fix(test): adapt procedural language test for Cloudberry behavior#24
Merged
gfphoenix78 merged 1 commit intoapache:sync-with-upstreamfrom Aug 28, 2025
Merged
Conversation
The integration test for procedural languages was failing on Cloudberry due to differences in dependency handling compared to GPDB 7. In Cloudberry (based on PostgreSQL 14), extension-created languages are marked as "core extension members" and are correctly filtered out by the existing GetProceduralLanguages() function to avoid backup duplication. This commit updates the test to: 1. Create the extension first in Cloudberry to make handlers available 2. Use appropriate cleanup strategy (DROP EXTENSION vs DROP LANGUAGE) 3. Expect length 0 for Cloudberry (filtered) vs length 1 for GPDB The changes ensure test compatibility while confirming that the backup logic correctly handles different PostgreSQL dependency models. Fixes: Integration test failure in predata_functions_create_test.go
gfphoenix78
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test for procedural languages was failing on Cloudberry due to differences in dependency handling compared to GPDB 7.
In Cloudberry (based on PostgreSQL 14), extension-created languages are marked as "core extension members" and are correctly filtered out by the existing GetProceduralLanguages() function to avoid backup duplication.
This commit updates the test to:
The changes ensure test compatibility while confirming that the backup logic correctly handles different PostgreSQL dependency models.
Fixes: Integration test failure in predata_functions_create_test.go