fix(test): adjust stored procedure test expectations for Cloudberry#26
Merged
gfphoenix78 merged 1 commit intoapache:sync-with-upstreamfrom Aug 28, 2025
Merged
Conversation
The integration test for stored procedures was failing on Cloudberry due to differences in pg_get_function_arguments behavior compared to GPDB 7. In Cloudberry (PostgreSQL 14), pg_get_function_arguments includes parameter modes (e.g., "IN") in the returned arguments string, while GPDB 7 omits them. This commit updates the test to expect the correct format for each database version: - Cloudberry: "IN a integer, IN b integer" - GPDB 7: "a integer, b integer" The underlying gpbackup functionality works correctly on both platforms; only the test expectations needed adjustment. Fixes: Integration test failure in predata_functions_queries_test.go
gfphoenix78
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test for stored procedures was failing on Cloudberry due to differences in pg_get_function_arguments behavior compared to GPDB 7.
In Cloudberry (based onPostgreSQL 14), pg_get_function_arguments includes parameter modes (e.g., "IN") in the returned arguments string, while GPDB 7 omits them.
This commit updates the test to expect the correct format for each database version:
The underlying gpbackup functionality works correctly on both platforms; only the test expectations needed adjustment.
Fixes: Integration test failure in predata_functions_queries_test.go