Skip to content

fix(test): Remove ELEMENT parameter for Cloudberry compatibility #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfphoenix78 merged 1 commit into from
Aug 28, 2025
Merged

fix(test): Remove ELEMENT parameter for Cloudberry compatibility #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion integration/predata_types_queries_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,21 @@ var _ = Describe("backup integration tests", func() {
if connectionPool.Version.IsGPDB() && connectionPool.Version.Before("6") {
testhelper.AssertQueryRuns(connectionPool, "CREATE TYPE public.base_type(INPUT=public.base_fn_in, OUTPUT=public.base_fn_out, INTERNALLENGTH=8, PASSEDBYVALUE, ALIGNMENT=double, STORAGE=plain, DEFAULT=0, ELEMENT=integer, DELIMITER=';')")
} else {
testhelper.AssertQueryRuns(connectionPool, "CREATE TYPE public.base_type(INPUT=public.base_fn_in, OUTPUT=public.base_fn_out, INTERNALLENGTH=8, PASSEDBYVALUE, ALIGNMENT=double, STORAGE=plain, DEFAULT=0, ELEMENT=integer, DELIMITER=';', CATEGORY='N', PREFERRED=true, COLLATABLE=true)")
/*
* In PostgreSQL 14 (Cloudberry is based on), the validation for CREATE TYPE has become stricter.
* The 'ELEMENT' parameter can only be specified if a 'subscripting function' is also
* provided for the type.
*
* PostgreSQL 12 (GPDB 7 is based on) was more lenient and allowed specifying 'ELEMENT'
* as a metadata-only attribute without enforcing the presence of a subscripting
* function, even though the type would not actually support subscripting.
*
* Since this test's primary purpose is to verify the backup of other custom
* type properties (like alignment, storage, etc.) and not to create a
* fully-functional array-like type, we remove the 'ELEMENT=integer' clause
* test case to comply with the stricter checks.
*/
testhelper.AssertQueryRuns(connectionPool, "CREATE TYPE public.base_type(INPUT=public.base_fn_in, OUTPUT=public.base_fn_out, INTERNALLENGTH=8, PASSEDBYVALUE, ALIGNMENT=double, STORAGE=plain, DEFAULT=0, DELIMITER=';', CATEGORY='N', PREFERRED=true, COLLATABLE=true)")
}
testhelper.AssertQueryRuns(connectionPool, "ALTER TYPE public.base_type SET DEFAULT ENCODING (compresstype=zlib)")

Expand All @@ -128,6 +142,7 @@ var _ = Describe("backup integration tests", func() {
baseTypeCustom.Category = "N"
baseTypeCustom.Preferred = true
baseTypeCustom.Collatable = true
baseTypeCustom.Element = ""
structmatcher.ExpectStructsToMatchExcluding(&baseTypeCustom, &results[0], "Oid")
}
})
Expand Down