Fix: Normalize operator class storagetype for different DB versions#33
Merged
gfphoenix78 merged 1 commit intoapache:sync-with-upstreamfrom Sep 5, 2025
Merged
Conversation
This commit addresses a test failure in the `GetOperatorClasses` integration tests, which was observed on newer database versions like Cloudberry (based on PG14). The investigation revealed an inconsistency in how Greenplum 7 (based on PG12) and Cloudberry handle the `storagetype` for operator classes. When an operator class's `STORAGE` type is the same as its `FOR TYPE` and `opckeytype` is not 0: - In GPDB7, the expression `opckeytype::regtype` evaluates to "-". - In CBDB, the same expression evaluates to the actual type name (e.g., "integer"). This change introduces a `CASE` statement to explicitly check if `opcintype` equals `opckeytype`. This normalizes the behavior across both database versions, ensuring that `storagetype` is consistently represented as "-" when the storage type is the same as the input type, which allows the failing test to pass.
gfphoenix78
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a test failure in the
GetOperatorClassesintegration tests, which was observed on newer database versions like Cloudberry (based on PG14).The investigation revealed an inconsistency in how Greenplum 7 (based on PG12) and Cloudberry handle the
storagetypefor operator classes. When an operator class'sSTORAGEtype is the same as itsFOR TYPEandopckeytypeis not 0:opckeytype::regtypeevaluates to "-".This change introduces a
CASEstatement to explicitly check ifopcintypeequalsopckeytype. This normalizes the behavior across both database versions, ensuring thatstoragetypeis consistently represented as "-" when the storage type is the same as the input type, which allows the failing test to pass.