Skip to content

Fix release tarball base version naming#76

Open
tuhaihe wants to merge 1 commit intoapache:mainfrom
tuhaihe:fix-release-tarball-naming
Open

Fix release tarball base version naming#76
tuhaihe wants to merge 1 commit intoapache:mainfrom
tuhaihe:fix-release-tarball-naming

Conversation

@tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Mar 4, 2026

For RC tags like X.Y.Z-incubating-rcN, generate the source tarball filename and top-level directory using VERSION_FILE (without -rcN).

$VERSION_FILE is input from the file VERSION.

This keeps the voted bits ready for promotion without rebuilding and avoids -rcN showing up in the extracted source directory.

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist

Here are some reminders before you submit your pull request:

For RC tags like X.Y.Z-incubating-rcN, generate the source tarball
filename and top-level directory using VERSION_FILE (without -rcN).

$VERSION_FILE is input from the file VERSION.

This keeps the voted bits ready for promotion without rebuilding and
avoids -rcN showing up in the extracted source directory.
@robertmu robertmu self-requested a review March 23, 2026 10:37
Copy link
Contributor

@robertmu robertmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like that the top-level extracted directory now uses VERSION_FILE, but the tarball filename still uses TAG (TAR_NAME="apache-cloudberry-backup-${TAG}-src.tar.gz"). If the intent is to remove -rcN from both directory and filename, Should we also switch TAR_NAME to use VERSION_FILE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants