Skip to content
This repository was archived by the owner on Sep 12, 2025. It is now read-only.

Add initial Dockerfiles, configs, and GitHub workflows for Cloudberry#2

Merged
edespino merged 1 commit intoapache:mainfrom
edespino:docker-images
Nov 14, 2024
Merged

Add initial Dockerfiles, configs, and GitHub workflows for Cloudberry#2
edespino merged 1 commit intoapache:mainfrom
edespino:docker-images

Conversation

@edespino
Copy link
Copy Markdown
Contributor

  • Include Dockerfiles for Rocky Linux 8 and 9 based build and test environments
  • Add test scripts, configuration files, and automation support for containerized builds
  • Provide necessary scripts for testing and deploying across both supported environments
  • Add GitHub workflow files for building and testing containersAdd initial Dockerfiles and configs for Cloudberry

@edespino edespino requested a review from tuhaihe November 14, 2024 08:52
tuhaihe
tuhaihe previously approved these changes Nov 14, 2024
Copy link
Copy Markdown
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Ed! I just left some comments from a non-technical perspective for your information.

@tuhaihe
Copy link
Copy Markdown
Member

tuhaihe commented Nov 14, 2024

The commit message can add a new line for the last one:
- Add GitHub workflow files for building and testing containers
- Add initial Dockerfiles and configs for Cloudberry

- Include Dockerfiles for Rocky Linux 8 and 9 based build and test
  environments
- Add test scripts, configuration files, and automation support for
  containerized builds
- Provide necessary scripts for testing and deploying across both
  supported environments
- Add GitHub workflow files for building and testing containers
- Add initial Dockerfiles and configs for Cloudberry
@edespino edespino merged commit 7f82c00 into apache:main Nov 14, 2024
# --------------------------------------------------------------------
# Dockerfile for Apache Cloudberry Build Environment
# --------------------------------------------------------------------
# This Dockerfile sets up a Rocky Linux 9-based container for building
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your contributions to the team have been invaluable. I just finished reading all the code. The process is very smooth and easy to understand. This is very helpful for me to understand the entire process. There is one place where I am wondering if it was a mistake. This Dockfile should be established as a Rocky Linux 8-based container for building.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zhangbaowen-Hashdata Thank you for the thorough review and kind feedback. I deliberately chose Rocky Linux 9 as our initial base platform. The plan is to expand support to additional platforms (including Rocky Linux 8, Ubuntu, and Debian) in upcoming iterations. For now, I wanted to focus on establishing solid automation processes for Apache Cloudberry (incubating) using a single platform as our foundation. Once we have that working smoothly, expanding to other distributions will be more straightforward.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants