Optimize AOCS scan performance by introducing specialized no-qual path#1009
Closed
yjhjstz wants to merge 1 commit intoapache:mainfrom
Closed
Optimize AOCS scan performance by introducing specialized no-qual path#1009yjhjstz wants to merge 1 commit intoapache:mainfrom
yjhjstz wants to merge 1 commit intoapache:mainfrom
Conversation
This patch improves the performance of Append-Only Columnar Store (AOCS) table scans by introducing `aocs_getnext_noqual`, a specialized scan function optimized for cases where no scan qualifiers are present. This change helps avoid unnecessary checks, reducing CPU overhead during sequential scans. Key changes: - Added `aocs_getnext_noqual`, which eliminates redundant checks in scans. - Marked `upgrade_datum_scan` as `pg_attribute_unused()` to suppress unused warnings. - Introduced `pg_attribute_hot_inline` for `aocs_getnext_noqual` to improve inlining efficiency. - Refactored related scan functions to integrate the optimized path while maintaining correctness. These changes are expected to improve scan efficiency for AOCS tables, especially for full-table sequential scans. Author: Jianghua Yang
yjhjstz
added
the
type: Performance
Member
Author
|
move to #1010 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves the performance of Append-Only Columnar Store (AOCS) table scans by introducing
aocs_getnext_noqual, a specialized scan function optimized for cases where no scan qualifiers are present. This change helps avoid unnecessary checks, reducing CPU overhead during sequential scans.Key changes:
aocs_getnext_noqual, which eliminates redundant checks in scans.upgrade_datum_scanaspg_attribute_unused()to suppress unused warnings.pg_attribute_hot_inlineforaocs_getnext_noqualto improve inlining efficiency.These changes are expected to improve scan efficiency for AOCS tables, especially for full-table sequential scans.
Author: Jianghua Yang
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions