Update bash $PATH in gpdemo for better portability#1162
Merged
tuhaihe merged 1 commit intoapache:mainfrom Jun 18, 2025
Merged
Conversation
yjhjstz
approved these changes
Jun 18, 2025
Replace hardcoded `/usr/bin/bash` path with `/usr/bin/env bash` in gpAux/gpdemo/Makefile to improve portability across different systems. This change ensures the demo cluster can be created regardless of where bash is installed on the system. Will return the following errors when testing under Ubuntu 18.04 container: ``` gpadmin@cdw:~/cloudberry$ make create-demo-cluster -C ~/cloudberry make: Entering directory '/home/gpadmin/cloudberry' make -C gpAux/gpdemo create-demo-cluster make[1]: Entering directory '/home/gpadmin/cloudberry/gpAux/gpdemo' make[1]: /usr/bin/bash: Command not found ``` This change makes the demo environment more robust across different Linux distributions, container environments, and custom installations.
tuhaihe
force-pushed
the
update-gpdemo-bash-path
branch
from
56d93e9 to
96f80ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded
/usr/bin/bashpath with/usr/bin/env bashin gpAux/gpdemo/Makefile to improve portability across different systems. This change ensures the demo cluster can be created regardless of where bash is installed on the system.Will return the following errors when testing under Ubuntu 18.04 container:
This change makes the demo environment more robust across different Linux distributions, container environments, and custom installations.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions