Make gp_cte_sharing globally configurable#1403
Merged
avamingli merged 1 commit intoapache:mainfrom Oct 17, 2025
Merged
Conversation
67f0d5c to
3d68476
Compare
During CTE feature development, we discovered that the gp_cte_sharing GUC cannot be configured at the server level, which complicates testing of CTE sharing functionality. This GUC was introduced ten years ago, and there is no apparent reason why it should not be configurable globally. This change enables more flexible testing and deployment configurations. Authored-by: Zhang Mingli avamingli@gmail.com
3d68476 to
0547d57
Compare
my-ship-it
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During CTE feature development, we discovered that the gp_cte_sharing GUC
cannot be configured at the server level, which complicates testing of CTE sharing functionality.
This GUC was introduced ten years ago, and there is no apparent reason why it should not be configurable globally. This change enables more flexible testing and deployment configurations.
Authored-by: Zhang Mingli avamingli@gmail.com
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions