Skip to content

Make gp_cte_sharing globally configurable#1403

Merged
avamingli merged 1 commit intoapache:mainfrom
avamingli:config_gp_cte_sharing
Oct 17, 2025
Merged

Make gp_cte_sharing globally configurable#1403
avamingli merged 1 commit intoapache:mainfrom
avamingli:config_gp_cte_sharing

Conversation

@avamingli
Copy link
Contributor

During CTE feature development, we discovered that the gp_cte_sharing GUC
cannot be configured at the server level, which complicates testing of CTE sharing functionality.

This GUC was introduced ten years ago, and there is no apparent reason why it should not be configurable globally. This change enables more flexible testing and deployment configurations.

Authored-by: Zhang Mingli avamingli@gmail.com

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@avamingli avamingli force-pushed the config_gp_cte_sharing branch from 67f0d5c to 3d68476 Compare October 17, 2025 06:37
@avamingli avamingli requested a review from my-ship-it October 17, 2025 09:04
Copy link
Contributor

@Smyatkin-Maxim Smyatkin-Maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

During CTE feature development, we discovered that the gp_cte_sharing
GUC
cannot be configured at the server level, which complicates testing of
CTE sharing functionality.

This GUC was introduced ten years ago, and there is no apparent reason
why it should not be configurable globally. This change enables more
flexible testing and deployment configurations.

Authored-by: Zhang Mingli avamingli@gmail.com
@my-ship-it my-ship-it force-pushed the config_gp_cte_sharing branch from 3d68476 to 0547d57 Compare October 17, 2025 10:12
@avamingli avamingli merged commit f799d10 into apache:main Oct 17, 2025
28 checks passed
@avamingli avamingli deleted the config_gp_cte_sharing branch October 17, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants