Skip to content

Fix for CBDB expand with concurrent distributed tx #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reshke wants to merge 1 commit into
base: REL_2_STABLE
Choose a base branch
from
+11 −0
Open

Fix for CBDB expand with concurrent distributed tx #1801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/backend/cdb/cdbdtxrecovery.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,17 @@ redoDistributedCommitRecord(DistributedTransactionId gxid)
int i;
bool is_hot_standby_qd = IS_HOT_STANDBY_QD();

/*
* The coordinator may execute write DTX during gpexpand, so the newly
* added segment may contain DTX info in checkpoint XLOG. However, this step
* is useless and should be avoided for segments, or fatal may be thrown since
* max_tm_gxacts is 0 in segments. See also fc8aab88d
*/
if (ConvertMasterDataDirToSegment && !IS_QUERY_DISPATCHER())
Comment thread
reshke marked this conversation as resolved.
{
return;
}

/*
* Only the startup process can be modifying shmNumCommittedGxacts
* and shmCommittedGxidArray. So should be OK reading the value w/o lock.
Expand Down
Loading