Skip to content

Conversation

@gongxun0928
Copy link
Contributor

@gongxun0928 gongxun0928 commented Sep 19, 2023


Change logs

  1. support non-dispatch analyze operation for custom table am in cloudberry.
  2. added a void *context parameter to scan_begin to pass some additional parameters

Why are the changes needed?

we want to support custom table am to support analyze operations without modifying the kernel every time

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

@gongxun0928 gongxun0928 force-pushed the feature/support-analyze-and-remove-dispatch-hook branch 2 times, most recently from a5ef390 to 2473f6b Compare September 25, 2023 08:00
@my-ship-it my-ship-it merged commit b590e99 into apache:union_store_catalog Sep 26, 2023
@gongxun0928 gongxun0928 deleted the feature/support-analyze-and-remove-dispatch-hook branch September 24, 2024 09:29
oppenheimer01 pushed a commit to oppenheimer01/cloudberrydb that referenced this pull request Apr 11, 2025
use new struct AnalyzeContext instead of gp_acquire_sample_rows_context to pass analyze context in table_beginscan_analyze
oppenheimer01 pushed a commit to oppenheimer01/cloudberrydb that referenced this pull request Apr 23, 2025
use new struct AnalyzeContext instead of gp_acquire_sample_rows_context to pass analyze context in table_beginscan_analyze
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants