change storage_am related catalog table main_manifest field type from… #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… uint32 to uint64, and change the name from relid to relnode
|
|
my-ship-it
reviewed
Sep 20, 2023
Member
|
Hi, @wangliang03, thanks for your work! Please rewrite your commit message title and body following our commit convention. TYVM. |
my-ship-it
approved these changes
Sep 21, 2023
oppenheimer01
pushed a commit
to oppenheimer01/cloudberrydb
that referenced
this pull request
Apr 11, 2025
apache#210) Change storage_am related catalog table main_manifest field type from uint32 to uint64, and change the name from relid to relnode Co-authored-by: xiaosongwang <xiaosongwang03@gmail.com>
oppenheimer01
pushed a commit
to oppenheimer01/cloudberrydb
that referenced
this pull request
Apr 23, 2025
apache#210) Change storage_am related catalog table main_manifest field type from uint32 to uint64, and change the name from relid to relnode Co-authored-by: xiaosongwang <xiaosongwang03@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… uint32 to uint64,
and change the name from relid to relnode
we did the same change on storage_am, the main_manifest is a system catalog, storage_am has dependencies on this change.
storage_am will use the relfilenode as the identifier instead of relid, and currenlty relfilenode is uint64 and relid is uint32.