Skip to content

Conversation

@andrijapanicsb
Copy link
Contributor

No description provided.

@andrijapanicsb
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr56

Build Log Output:

No log errors found to report.

@andrijapanicsb
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr56

Build Log Output:

No log errors found to report.

@andrijapanicsb andrijapanicsb requested a review from nvazquez July 24, 2019 12:05
@andrijapanicsb
Copy link
Contributor Author

@shwstppr kindly review

@andrijapanicsb
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr56

Build Log Output:

No log errors found to report.

@nvazquez
Copy link
Contributor

Thanks @andrijapanic LGTM

@andrijapanicsb andrijapanicsb merged commit f975a0c into master Jul 24, 2019
@andrijapanicsb andrijapanicsb deleted the doc-update-iso-from-local branch July 24, 2019 12:37
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor subjective changes. LGTM

.. warning::
If you are uploading a template that was created using vSphere Client,
be sure the OVA file does not contain an ISO. If it does, the deployment
of VMs from the template will fail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of VMs from the template will fail
of VMs from the template will fail.

Not sure if this was deliberate.

<systemvm.html#using-a-ssl-certificate-for-the-console-proxy>`_.)
<systemvm.html#using-a-ssl-certificate-for-the-console-proxy>`_).

Example GUI dialog of uploading (ISO) from local (browser) is given below:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example GUI dialog of uploading (ISO) from local (browser) is given below:
Example UI dialog of uploading (ISO) from local (browser) is given below:

Do we always mention our GUI as UI? And maybe we don't even have mention this line as other parts of doc simply adds screenshots without explicitly mentioning them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants