Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

[WIP] Added core-js@3 dependency#15

Closed
onitake wants to merge 1 commit intoapache:masterfrom
swisstxt:fix/core-js
Closed

[WIP] Added core-js@3 dependency#15
onitake wants to merge 1 commit intoapache:masterfrom
swisstxt:fix/core-js

Conversation

@onitake
Copy link
Contributor

@onitake onitake commented Nov 12, 2019

Fixes #11 .

TODO Still needs to be tested.

@yadvr
Copy link
Member

yadvr commented Nov 12, 2019

@onitake can you check, Travis is failing. You probably need to run npm install and commit the package lock file.

@onitake
Copy link
Contributor Author

onitake commented Nov 13, 2019

Yes, I thought as much.
I haven't had time to test it on my test instance yet, will do that today.

@yadvr
Copy link
Member

yadvr commented Nov 13, 2019

Created a new PR based on this PR @onitake cc @GabrielBrascher

@onitake
Copy link
Contributor Author

onitake commented Nov 13, 2019

Closing in favour of #16

@onitake onitake closed this Nov 13, 2019
@onitake onitake deleted the fix/core-js branch November 19, 2019 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime issues due incompatible core-js dependency

3 participants