Add nexthop parameter to cloudstack_static_route resource#284
Open
bhouse-nexthop wants to merge 1 commit intoapache:mainfrom
Open
Add nexthop parameter to cloudstack_static_route resource#284bhouse-nexthop wants to merge 1 commit intoapache:mainfrom
bhouse-nexthop wants to merge 1 commit intoapache:mainfrom
Conversation
This change adds support for the nexthop parameter in static routes, which allows VPC-based routing without requiring a private gateway. Resource Changes: - Add nexthop and vpc_id optional parameters to schema - nexthop is mutually exclusive with gateway_id - When using nexthop, vpc_id is required - When using gateway_id, nexthop and vpc_id are not allowed - Update resource creation logic to support both routing methods: - Private Gateway routing (gateway_id) - VPC direct routing (nexthop + vpc_id) - Update Read function to maintain plan stability for both modes Test Coverage: - Add comprehensive test coverage for both routing methods - Add testAccPreCheckStaticRouteNexthop helper to check CloudStack version - Automatically skip nexthop tests on CloudStack versions < 4.22.0 - Version check uses CloudStack capabilities API - Tests are skipped (not failed) on older versions for backward compatibility - All acceptance tests passing (2/2) Documentation: - Update documentation with examples for both routing methods - Document mutual exclusivity requirements - Note CloudStack 4.22+ requirement for nexthop support CI/CD: - Add CloudStack 4.22.0.0 to acceptance test matrix - Ensures tests run on both old and new CloudStack versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for the nexthop parameter in static routes, which allows VPC-based routing without requiring a private gateway id.
Resource Changes:
Test Coverage:
Documentation:
CI/CD: