configdrive testing needs refactorring

[DaanHoogland]

Config drive refactoring has led to an external utility being used in a unittest for it (genisoimage). This test must be done, however but in an integration test.
#2665 deletes the original test
#2651 introduced the change and has validity so we should keep the new way of creating the configdrive and only change the way of testing it.

ISSUE TYPE

• Other (test improvement)

COMPONENT NAME

CLOUDSTACK VERSION

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

[DaanHoogland]

as #2665 now mocks the tool, I am wondering if we need an integration style test still. @rafaelweingartner @wido @fmaximus @mike-tutkowski can any of you comment? /cc @rhtyd

[wido]

If we have a proper Mock we do not need a integration test I think

[rafaelweingartner]

@wido that is the idea. It might be a good idea to have an "integration"/API test (those written in python) that calls the API that in turn uses the execution flow, which uses this configDriver block of code

[DaanHoogland]

So, what do we dicide? I think @rafaelweingartner 's tests are fine. I didn't check if we can skip the tests in #2673 but the macos fix I still want in.
comments, @wido @rhtyd @PaulAngus

[rafaelweingartner]

+1 to merge it if we are going to cut another RC. Not sure what to do if we are going to close release with the current RC.

[DaanHoogland]

merge and merge forward, but then still, do we merge #2673 as well?

[rafaelweingartner]

There seems to be some questions there, but I guess we should merge #2673 as well. It is fixing some integration tests.

[DaanHoogland]

sorry, no I've been confusing stuff. I mean #2665

[rafaelweingartner]

#2665 is deprecated by my PR

[DaanHoogland]

not entirely, but i'll create a separate PR for the macos bit, after verifying it actually does creates configdrives

[rafaelweingartner]

You mean, using the path to the program that is expected in the MacOS?

[DaanHoogland]

never mind @rafaelweingartner , I found the code in your PR