Switch instance to another compute/service offering

[pbankonier]

ISSUE TYPE

• Bug Report

COMPONENT NAME

Server

CLOUDSTACK VERSION

Master

CONFIGURATION

N/A 

OS / ENVIRONMENT

We are using managed storage (Solidfire).

SUMMARY

Not possible to change a service offering for an instance to a newly created compute offering.
The problem are the changes in https://github.com/apache/cloudstack/pull/3133/files in the ConfigurationManagerImpl.java.
When issystem is passed as false and iscusstomizediops is null when you create a compute offering the values gets set to 0 instead of null.

STEPS TO REPRODUCE

Create a new compute offering.
Change the service offering of an instance to the newly created compute offering.

EXPECTED RESULTS

The values for minIops and maxIops are set to null and it is possible to change the
offering for the instance.

ACTUAL RESULTS

The values for minIops and maxIops are set to 0.
An error is thrown ("The minIOPS value must be between 50 and 15000").

[nathanejohnson]

I will take a look

[nathanejohnson]

@pbankonier from looking at the code prior to this PR, it looks like this behavior predates it. Are you using the UI or creating the service offering via API?

[svenvogel]

@nathanejohnson we use the UI.

[pbankonier]

@nathanejohnson The problem is from line 2371 in the ConfigurationManagerImpl.java. You changed the condition from 'isCustomizedIops != null' to 'Boolean.TRUE.equals(isCustomizedIops)' and removed the else case where minIops and maxIops gets set to null;
This changes the behavior in case isCustomizedIops is null. Now the minIops and maxIops values get set to 0 instead of null.

[nathanejohnson]

@pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in.

[nathanejohnson]

@svenvogel if you use cloudmonkey to create the service offering and omit the iscusomizediops flag, I believe it should do what you want it to.

[svenvogel]

@nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? if you see the pictures below from DB which i added you will see in the old offering there will be add a "0" NOT "NULL". normally there should be a "NULL" because we dont chosen a QOS Type Storage!

@syed @mike-tutkowski can you take a look?

@pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous logic, it still sets miniops and maxiops to 0 in this case. Which is what it still does. I agree that it probably shouldn't, but this is why I asked on the PR for someone more familiar with managed storage (@mike-tutkowski ) to weigh in.

@pbankonier what do you think? why it worked before?

DB View

[nathanejohnson]

@svenvogel long-term we should make sure that this works from the UI. in the short term, I believe a workaround for you might be to use cloudmonkey. https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+cloudmonkey+CLI

If you need help setting it up, please feel free to pop into the slack channel or the freenode irc channel.