Restart a vpc tier with cleanup should not cleanup the whole VPC

[weizhouapache]

ISSUE TYPE

• Bug Report

COMPONENT NAME

VR/network

CLOUDSTACK VERSION

4.16.0.0-rc1

CONFIGURATION

advanced networking

OS / ENVIRONMENT

kvm

SUMMARY

ideally restart a vpc network will remove the guest nic and replug it in VPC VR.
but actually VPC VR is destroyed and a new VPC VR is created.

STEPS TO REPRODUCE

1. create vpc
2. create vpc tier
3. create vm in vpc tier
4. restart vpc tier with cleanup

EXPECTED RESULTS

guest nic is removed from vpc vr and replugged.

ACTUAL RESULTS

VPC VR is destroyed and a new VPC VR is created.

[DaanHoogland]

@weizhouapache cleanup means remove the VR in fact. I think the only way to prevent this is to forbid cleanup for tiers. The solution you proposes seems like a regular restart.

[weizhouapache]

@weizhouapache cleanup means remove the VR in fact. I think the only way to prevent this is to forbid cleanup for tiers. The solution you proposes seems like a regular restart.

@DaanHoogland
as far as I remember, the behavior was not same as it before.
forbid cleanup for vpc tiers is an good option. At least there should be a warning message that the whole VPC will be impacted.

this is a minor issue.

[DaanHoogland]

@weizhouapache cleanup means remove the VR in fact. I think the only way to prevent this is to forbid cleanup for tiers. The solution you proposes seems like a regular restart.

@DaanHoogland as far as I remember, the behavior was not same as it before. forbid cleanup for vpc tiers is an good option. At least there should be a warning message that the whole VPC will be impacted.

agreed

[sureshanaparti]

Fixed in #5873