vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

[weizhouapache]

in vmx file, the scsiX.virtualDev is not changed to "pvscsi" when root and data disk controller are set to "pvscsi"

ISSUE TYPE

• Bug Report

COMPONENT NAME

vmware

CLOUDSTACK VERSION

4.16

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

By default, the scsiX.virtualDev is "lsilogic".
when I set root and data disk controller to "pvscsi", I expect that the scsiX.virtualDev is changed to "pvscsi".

STEPS TO REPRODUCE

1. create a vm and start it

the vm has config in vmx file

# grep scsi /vmfs/volumes/85f59f3e-422b762e/i-2-4-VM/i-2-4-VM.vmx
scsi0.virtualDev = "lsilogic"
scsi0.present = "TRUE"
scsi1.virtualDev = "lsilogic"
scsi1.present = "TRUE"
scsi2.virtualDev = "lsilogic"
scsi2.present = "TRUE"
scsi3.virtualDev = "lsilogic"
scsi3.present = "TRUE"
scsi0.pciSlotNumber = "16"
scsi1.pciSlotNumber = "32"
scsi2.pciSlotNumber = "33"
scsi3.pciSlotNumber = "34"

2. stop the vm, and change  vm setting

rootDiskController=pvscsi
dataDiskController=pvscsi

3. start the vm


# grep scsi /vmfs/volumes/85f59f3e-422b762e/i-2-4-VM/i-2-4-VM.vmx
scsi0.virtualDev = "lsilogic"
scsi0.present = "TRUE"
scsi1.virtualDev = "lsilogic"
scsi1.present = "TRUE"
scsi2.virtualDev = "lsilogic"
scsi2.present = "TRUE"
scsi3.virtualDev = "lsilogic"
scsi3.present = "TRUE"
scsi0.pciSlotNumber = "16"
scsi1.pciSlotNumber = "32"
scsi2.pciSlotNumber = "33"
scsi3.pciSlotNumber = "34"
scsi0:0.deviceType = "scsi-hardDisk"
scsi0:0.fileName = "ROOT-4.vmdk"
scsi0:0.present = "TRUE"
dataDiskController = "pvscsi"
rootDiskController = "pvscsi"
scsi0:0.redo = ""

EXPECTED RESULTS

scsi0.virtualDev = "pvscsi"
scsi0.present = "TRUE"
scsi1.virtualDev = "pvscsi"
scsi1.present = "TRUE"
scsi2.virtualDev = "pvscsi"
scsi2.present = "TRUE"
scsi3.virtualDev = "pvscsi"
scsi3.present = "TRUE"

ACTUAL RESULTS

scsi0.virtualDev = "lsilogic"
scsi0.present = "TRUE"
scsi1.virtualDev = "lsilogic"
scsi1.present = "TRUE"
scsi2.virtualDev = "lsilogic"
scsi2.present = "TRUE"
scsi3.virtualDev = "lsilogic"
scsi3.present = "TRUE"

[yadvr]

@weizhouapache @sureshanaparti let's check VMwareResourceBase, it might be a historic limitation that under some circumstance controllers are not always added as configured in the template/disk controller properties.

[sureshanaparti]

@weizhouapache @sureshanaparti let's check VMwareResourceBase, it might be a historic limitation that under some circumstance controllers are not always added as configured in the template/disk controller properties.

@rohityadavcloud Correct, pvscsi controller is bypassed to use lsilogic controller when the support for different scsi controller types was introduced. It seems the vmdk property "ddb.adapterType" is not properly set for pvscsi controller, and also it is not supported for virtual hardware version < 7. May be, we have to re-visit it and check whether the limitation still exists or not.

cloudstack/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VmdkAdapterType.java

Lines 30 to 31 in 7f000f5

	} else if (diskControllerType == DiskControllerType.lsilogic || diskControllerType == DiskControllerType.pvscsi || diskControllerType == DiskControllerType.lsisas1068) {
	return VmdkAdapterType.lsilogic;

cloudstack/vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java

Lines 708 to 711 in 7f000f5

	// By-pass auto detected PVSCSI controller to use LsiLogic Parallel instead
	if (DiskControllerType.getType(recommendedController) == DiskControllerType.pvscsi) {
	recommendedController = DiskControllerType.lsilogic.toString();
	}

[sureshanaparti]

Hi @weizhouapache Have you noticed any logs indicating 'pvscsi' controller is bypassed to use 'lsilogic' controller?

[weizhouapache]

@sureshanaparti @rohityadavcloud
no, I did not notice such logs.
I have investigated the issue and found that cloudstack does not update existing disk.

cloudstack/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

Lines 1776 to 1793 in 7f000f5

	// This VM needs SCSI controllers.
	// Get count of existing scsi controllers. Helps not to attempt to create more than the maximum allowed 4
	// Get maximum among the bus numbers in use by scsi controllers. Safe to pick maximum, because we always go sequential allocating bus numbers.
	Ternary<Integer, Integer, DiskControllerType> scsiControllerInfo = vmMo.getScsiControllerInfo();
	int requiredNumScsiControllers = VmwareHelper.MAX_SCSI_CONTROLLER_COUNT - scsiControllerInfo.first();
	int availableBusNum = scsiControllerInfo.second() + 1; // method returned current max. bus number
	if (requiredNumScsiControllers == 0) {
	return;
	}
	if (scsiControllerInfo.first() > 0) {
	// For VMs which already have a SCSI controller, do NOT attempt to add any more SCSI controllers & return the sub type.
	// For Legacy VMs would have only 1 LsiLogic Parallel SCSI controller, and doesn't require more.
	// For VMs created post device ordering support, 4 SCSI subtype controllers are ensured during deployment itself. No need to add more.
	// For fresh VM deployment only, all required controllers should be ensured.
	return;
	}
	ensureScsiDiskControllers(vmMo, scsiDiskController, requiredNumScsiControllers, availableBusNum);

the workaround is
(1) create a vm, but not start it
(2) update vm settings, set root and data disk controller to 'pvscsi'
(3) start the vm
Then the vm will have correct SCSI controller.

[DaanHoogland]

fixed in #5910