Skip to content

Conversation

@jbampton
Copy link
Member

Description

This PR...

refs #12069

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

With pre-commit

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (86ae1fe) to head (f582a2a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12070   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15539    15540    +1     
=========================================
  Files          5911     5911           
  Lines        529359   529359           
  Branches      64655    64655           
=========================================
+ Hits          92979    92983    +4     
+ Misses       425920   425918    -2     
+ Partials      10460    10458    -2     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15758

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes Apache License headers across Shell files in the CloudStack repository by adding a pre-commit hook that automatically inserts properly formatted license headers. The changes ensure consistent formatting with a blank line after the shebang, followed by the license header, and another blank line before any additional comments or code.

  • Adds a new pre-commit hook configuration for automatically adding license headers to Shell files
  • Reformats existing license headers in Shell scripts to use consistent single-hash comment style
  • Moves file-specific usage comments to appear after the license header

Reviewed Changes

Copilot reviewed 6 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.pre-commit-config.yaml Adds new insert-license hook for Shell files using # comment style
tools/devcloud4/common/configure-network.sh Standardizes license header formatting and moves usage comment after license
systemvm/debian/opt/cloud/bin/prepare_pxe.sh Removes extra hash characters and standardizes spacing in license header
systemvm/debian/opt/cloud/bin/dnsmasq.sh Adds blank line after shebang and completes missing license header line
systemvm/debian/opt/cloud/bin/baremetal_snat.sh Standardizes license header from no-space format to proper spacing
scripts/vm/hypervisor/kvm/nsrkvmrestore.sh Converts double-hash to single-hash comment style and adds blank line
scripts/vm/hypervisor/kvm/nsrkvmbackup.sh Converts double-hash to single-hash comment style and adds blank line
scripts/vm/hypervisor/kvm/nasbackup.sh Converts double-hash to single-hash comment style and adds blank line
plugins/hypervisors/ovm3/src/test/resources/scripts/tail.sh Standardizes license header with proper spacing
plugins/hypervisors/ovm3/src/test/resources/scripts/socat.sh Standardizes license header with proper spacing
plugins/hypervisors/hyperv/buildagent.sh Standardizes license header formatting and adds blank lines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DaanHoogland DaanHoogland merged commit 39126a4 into apache:main Nov 14, 2025
28 checks passed
@jbampton jbampton deleted the license-headers-shell branch November 14, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants